linux-ext4 - Re: [PATCH] debugfs: quiet debugfs 'catastrophic' message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yvb6UzeX2Umg1ts+@mit.edu>
Date:   Fri, 12 Aug 2022 21:11:47 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     linux-ext4@...r.kernel.org, Dongyang Li <dongyang@....com>
Subject: Re: [PATCH] debugfs: quiet debugfs 'catastrophic' message

On Fri, Aug 05, 2022 at 04:06:07PM -0600, Andreas Dilger wrote:
> When debugfs runs with "-c", it prints a scary-looking message:
> 
>     catastrophic mode - not reading inode or group bitmaps
> 
> that is often misunderstood by users to mean that there is something
> wrong with the filesystem, when there is no problem at all.
> 
> Not reading the bitmaps is totally normal and expected behavior for
> the "-c" option, which is used to significantly shorten the debugfs
> command execution time by not reading metadata that isn't needed for
> commands run against very large filesystems.
> 
> Since there is often confusion about what this message means, it
> would be better to just avoid printing anything at all, since the
> use of "-c" is expressly requesting this behavior, and there are
> no messages printed out for other options.
> 
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>
> Reviewed-by: Dongyang Li <dongyang@....com>
> Change-Id: I59b26a601780544ab995aa4ca7ab0c2123c70118

Applied, thanks!

					- Ted