lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Aug 2022 15:50:02 +0100 From: Matthew Wilcox <willy@...radead.org> To: Siddh Raman Pant <code@...dh.me> Cc: david@...morbit.com, djwong@...nel.org, fgheet255t@...il.com, hch@...radead.org, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org, riteshh@...ux.ibm.com, syzbot+a8e049cd3abd342936b6@...kaller.appspotmail.com, syzkaller-bugs@...glegroups.com Subject: Re: [syzbot] WARNING in iomap_iter On Thu, Aug 18, 2022 at 04:41:17PM +0530, Siddh Raman Pant wrote: > include/uapi/linux/loop.h | 12 ++++++------ I don't think changing these from u64 to s64 is the right way to go. > 2 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index e3c0ba93c1a3..4ca20ce3158d 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -977,6 +977,9 @@ loop_set_status_from_info(struct loop_device *lo, > return -EINVAL; > } > > + if (info->lo_offset < 0 || info->lo_sizelimit < 0) > + return -EINVAL; > + > lo->lo_offset = info->lo_offset; > lo->lo_sizelimit = info->lo_sizelimit; I'd instead do it here: if (lo>lo_offset < 0 || lo->lo_sizelimit < 0) return -EINVAL;
Powered by blists - more mailing lists