linux-ext4 - Re: [PATCH v2 0/2] ext4, f2fs: stop using PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2022 12:21:54 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     linux-f2fs-devel@...ts.sourceforge.net,
        Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <chao@...nel.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-fscrypt@...r.kernel.org,
        linux-ext4@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v2 0/2] ext4, f2fs: stop using PG_error for fscrypt and
 fsverity

On Mon, Aug 22, 2022 at 11:27:19AM -0700, Eric Biggers wrote:
> On Mon, Aug 15, 2022 at 04:50:50PM -0700, Eric Biggers wrote:
> > This series changes ext4 and f2fs to stop using PG_error to track
> > decryption and verity errors.  This is a step towards freeing up
> > PG_error for other uses, as discussed at
> > https://lore.kernel.org/linux-fsdevel/Yn10Iz1mJX1Mu1rv@casper.infradead.org
> > 
> > Note: due to the interdependencies with fs/crypto/ and fs/verity/,
> > I couldn't split this up into separate patches for each filesystem.
> > I'd appreciate Acks from the ext4 and f2fs maintainers so that I can
> > take these patches.  Otherwise I'm not sure how to move them forward.
> > 
> > Changed v1 => v2:
> >    - Rebased onto v6.0-rc1 and resolved conflicts in f2fs.
> > 
> > Eric Biggers (2):
> >   fscrypt: stop using PG_error to track error status
> >   fsverity: stop using PG_error to track error status
> > 
> >  fs/crypto/bio.c         | 16 +++++++----
> >  fs/ext4/readpage.c      | 16 +++++------
> >  fs/f2fs/compress.c      | 64 ++++++++++++++++++++---------------------
> >  fs/f2fs/data.c          | 64 +++++++++++++++++++++++------------------
> >  fs/verity/verify.c      | 12 ++++----
> >  include/linux/fscrypt.h |  5 ++--
> >  6 files changed, 93 insertions(+), 84 deletions(-)
> > 
> > 
> > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> 
> I'd appreciate review from the f2fs folks on this series, as that's where the
> most complex changes are.
> 

There's already a merge conflict with f2fs/dev, in the second patch :-(

It's going to be hard get this series merged, due to cross-tree dependencies.

I'll try to take the first patch (which handles decryption only, and is smaller)
through the fscrypt tree for 6.1.  Then maybe the second patch can go through
the f2fs tree later.

- Eric