linux-ext4 - Re: [PATCH] iversion: update comments with info about atime updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <166125468756.23264.2859374883806269821@noble.neil.brown.name>
Date:   Tue, 23 Aug 2022 21:38:07 +1000
From:   "NeilBrown" <neilb@...e.de>
To:     "Jeff Layton" <jlayton@...nel.org>
Cc:     "Dave Chinner" <david@...morbit.com>,
        "Mimi Zohar" <zohar@...ux.ibm.com>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-nfs@...r.kernel.org, linux-xfs@...r.kernel.org,
        linux-ext4@...r.kernel.org,
        "Trond Myklebust" <trondmy@...merspace.com>
Subject: Re: [PATCH] iversion: update comments with info about atime updates

On Tue, 23 Aug 2022, Jeff Layton wrote:
> So, we can refer to that and simply say:
> 
> "If the function updates the mtime or ctime on the inode, then the
> i_version should be incremented. If only the atime is being updated,
> then the i_version should not be incremented. The exception to this rule
> is explicit atime updates via utimes() or similar mechanism, which
> should result in the i_version being incremented."

Is that exception needed?  utimes() updates ctime.

https://man7.org/linux/man-pages/man2/utimes.2.html

doesn't say that, but

https://pubs.opengroup.org/onlinepubs/007904875/functions/utimes.html

does, as does the code.

NeilBrown