lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220831103911.ubrkxc3yf46bdme3@quack3> Date: Wed, 31 Aug 2022 12:39:11 +0200 From: Jan Kara <jack@...e.cz> To: Zhang Yi <yi.zhang@...wei.com> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, cluster-devel@...hat.com, ntfs3@...ts.linux.dev, ocfs2-devel@....oracle.com, reiserfs-devel@...r.kernel.org, jack@...e.cz, tytso@....edu, akpm@...ux-foundation.org, axboe@...nel.dk, viro@...iv.linux.org.uk, rpeterso@...hat.com, agruenba@...hat.com, almaz.alexandrovich@...agon-software.com, mark@...heh.com, dushistov@...l.ru, hch@...radead.org, chengzhihao1@...wei.com, yukuai3@...wei.com Subject: Re: [PATCH 01/14] fs/buffer: remove __breadahead_gfp() On Wed 31-08-22 15:20:58, Zhang Yi wrote: > No one use __breadahead_gfp() and sb_breadahead_unmovable() any more, > remove them. > > Signed-off-by: Zhang Yi <yi.zhang@...wei.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/buffer.c | 11 ----------- > include/linux/buffer_head.h | 8 -------- > 2 files changed, 19 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 55e762a58eb6..a0b70b3239f3 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -1348,17 +1348,6 @@ void __breadahead(struct block_device *bdev, sector_t block, unsigned size) > } > EXPORT_SYMBOL(__breadahead); > > -void __breadahead_gfp(struct block_device *bdev, sector_t block, unsigned size, > - gfp_t gfp) > -{ > - struct buffer_head *bh = __getblk_gfp(bdev, block, size, gfp); > - if (likely(bh)) { > - ll_rw_block(REQ_OP_READ | REQ_RAHEAD, 1, &bh); > - brelse(bh); > - } > -} > -EXPORT_SYMBOL(__breadahead_gfp); > - > /** > * __bread_gfp() - reads a specified block and returns the bh > * @bdev: the block_device to read from > diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h > index 089c9ade4325..c3863c417b00 100644 > --- a/include/linux/buffer_head.h > +++ b/include/linux/buffer_head.h > @@ -214,8 +214,6 @@ struct buffer_head *__getblk_gfp(struct block_device *bdev, sector_t block, > void __brelse(struct buffer_head *); > void __bforget(struct buffer_head *); > void __breadahead(struct block_device *, sector_t block, unsigned int size); > -void __breadahead_gfp(struct block_device *, sector_t block, unsigned int size, > - gfp_t gfp); > struct buffer_head *__bread_gfp(struct block_device *, > sector_t block, unsigned size, gfp_t gfp); > void invalidate_bh_lrus(void); > @@ -340,12 +338,6 @@ sb_breadahead(struct super_block *sb, sector_t block) > __breadahead(sb->s_bdev, block, sb->s_blocksize); > } > > -static inline void > -sb_breadahead_unmovable(struct super_block *sb, sector_t block) > -{ > - __breadahead_gfp(sb->s_bdev, block, sb->s_blocksize, 0); > -} > - > static inline struct buffer_head * > sb_getblk(struct super_block *sb, sector_t block) > { > -- > 2.31.1 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists