lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Sep 2022 04:23:24 -0400 From: "Theodore Ts'o" <tytso@....edu> To: Zhang Yi <yi.zhang@...wei.com> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, cluster-devel@...hat.com, ntfs3@...ts.linux.dev, ocfs2-devel@....oracle.com, reiserfs-devel@...r.kernel.org, jack@...e.cz, akpm@...ux-foundation.org, axboe@...nel.dk, viro@...iv.linux.org.uk, rpeterso@...hat.com, agruenba@...hat.com, almaz.alexandrovich@...agon-software.com, mark@...heh.com, dushistov@...l.ru, hch@...radead.org, chengzhihao1@...wei.com, yukuai3@...wei.com Subject: Re: [PATCH v2 06/14] jbd2: replace ll_rw_block() On Thu, Sep 01, 2022 at 09:34:57PM +0800, Zhang Yi wrote: > ll_rw_block() is not safe for the sync read path because it cannot > guarantee that submitting read IO if the buffer has been locked. We > could get false positive EIO after wait_on_buffer() if the buffer has > been locked by others. So stop using ll_rw_block() in > journal_get_superblock(). We also switch to new bh_readahead_batch() > for the buffer array readahead path. > > Signed-off-by: Zhang Yi <yi.zhang@...wei.com> Thanks, looks good. Reviewed-by: Theodore Ts'o <tytso@....edu> - Ted
Powered by blists - more mailing lists