linux-ext4 - Re: [PATCH v5 2/8] vfs: support STATX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220907090900.ji3ilhyxbftptdma@wittgenstein>
Date:   Wed, 7 Sep 2022 11:09:00 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, linux-xfs@...r.kernel.org,
        linux-api@...r.kernel.org, linux-fscrypt@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH v5 2/8] vfs: support STATX_DIOALIGN on block devices

On Fri, Aug 26, 2022 at 11:58:45PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Add support for STATX_DIOALIGN to block devices, so that direct I/O
> alignment restrictions are exposed to userspace in a generic way.
> 
> Note that this breaks the tradition of stat operating only on the block
> device node, not the block device itself.  However, it was felt that
> doing this is preferable, in order to make the interface useful and
> avoid needing separate interfaces for regular files and block devices.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---

Looks good to me,
Reviewed-by: Christian Brauner (Microsoft) <brauner@...nel.org>