linux-ext4 - Re: [PATCH 0/5 v2] ext4: Fix performance regression with mballoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220907130226.da6urgbj3ayaa2qn@quack3>
Date:   Wed, 7 Sep 2022 15:02:26 +0200
From:   Jan Kara <jack@...e.cz>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        Thorsten Leemhuis <regressions@...mhuis.info>,
        Ted Tso <tytso@....edu>, Ojaswin Mujoo <ojaswin@...ux.ibm.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>
Subject: Re: [PATCH 0/5 v2] ext4: Fix performance regression with mballoc

On Wed 07-09-22 12:49:47, Jan Kara wrote:
> > Here the iostat as usual:
> > 
> > https://github.com/lategoodbye/mb_optimize_scan_regress/commit/f4ad188e0feee60bffa23a8e1ad254544768c3bd
> > 
> > There is just one thing, but not sure this if this comes from these patches.
> > If i call
> > 
> > cat /proc/fs/ext4/mmcblk1p2/mb_structs_summary
> > 
> > The kernel throw a NULL pointer derefence in
> > ext4_mb_seq_structs_summary_show
> 
> Yeah, likely a bug in my last patch. I didn't test my changes to the sysfs
> interface. Thanks for testing this, I'll have a look.

Indeed the procfs interface update was buggy. Attached is a new version of
patch 5 to fixup the interface (and a couple of whitespace issues) in the
previous version. I will resend the full series but I'll wait some more
time whether there are not other comments.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR

View attachment "0005-ext4-Use-buckets-for-cr-1-block-scan-instead-of-rbtr.patch" of type "text/x-patch" (18783 bytes)