linux-ext4 - Re: [PATCH v2 02/13] ext4: remove cantfind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220908084015.pwc3rwidmd7jvm3c@riteshh-domain>
Date:   Thu, 8 Sep 2022 14:10:15 +0530
From:   "Ritesh Harjani (IBM)" <ritesh.list@...il.com>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz,
        lczerner@...hat.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2 02/13] ext4: remove cantfind_ext4 error handler

On 22/09/03 11:01AM, Jason Yan wrote:
> The 'cantfind_ext4' error handler is just a error msg print and then
> goto failed_mount. This two level goto makes the code complex and not
> easy to read. The only benefit is that is saves a little bit code.
> However some branches can merge and some branches dot not even need it.
> So do some refactor and remove it.
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> Reviewed-by: Jan Kara <jack@...e.cz>
> ---
>  fs/ext4/super.c | 29 +++++++++++++----------------
>  1 file changed, 13 insertions(+), 16 deletions(-)

Looks good to me. 
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>