lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Sep 2022 07:55:14 -0400 From: "Theodore Ts'o" <tytso@....edu> To: liuzhiqiang26@...wei.com, linux-ext4@...r.kernel.org, adilger@...mcloud.com, zhanchengbin1@...wei.com Cc: "Theodore Ts'o" <tytso@....edu>, wuguanghao3@...wei.com, linfeilong@...wei.com Subject: Re: [PATCH] tune2fs: fix tune2fs segfault when ext2fs_run_ext3_journal() fails On Mon, 5 Sep 2022 19:16:03 +0800, Zhiqiang Liu wrote: > When ext2fs_run_ext3_journal() fails, tune2fs cmd will occur one > segfault problem as follows. > (gdb) bt > #0 0x00007fdadad69917 in ext2fs_mmp_stop (fs=0x0) at mmp.c:405 > #1 0x0000558fa5a9365a in main (argc=<optimized out>, argv=<optimized out>) at tune2fs.c:3440 > > misc/tune2fs.c: > main() > -> ext2fs_open2(&fs) > -> ext2fs_mmp_start > ...... > -> retval = ext2fs_run_ext3_journal(&fs) > -> if (retval) > // if ext2fs_run_ext3_journal fails, close and free fs. > -> ext2fs_close_free(&fs) > -> rc = 1 > -> goto closefs > ...... > closefs: > -> if (rc) > -> ext2fs_mmp_stop(fs) // fs has been set to NULL, boom!! > -> (ext2fs_close_free(&fs) ? 1 : 0); // close and free fs > > [...] Applied, thanks! [1/1] tune2fs: fix tune2fs segfault when ext2fs_run_ext3_journal() fails commit: 66ecb6abe5d2c74191bb4bc24f3da036e5fa1213 Best regards, -- Theodore Ts'o <tytso@....edu>
Powered by blists - more mailing lists