lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Sep 2022 20:29:50 +0530 From: "Ritesh Harjani (IBM)" <ritesh.list@...il.com> To: Zhiqiang Liu <liuzhiqiang26@...wei.com> Cc: tytso@....edu, Ext4 Developers List <linux-ext4@...r.kernel.org>, linfeilong <linfeilong@...wei.com>, zhanchengbin <zhanchengbin1@...wei.com>, wuguanghao <wuguanghao3@...wei.com> Subject: Re: [PATCH] ext2fs_open2: goto cleanup tag when image_header->magic_number != EXT2_ET_MAGIC_E2IMAGE On 22/09/13 09:14PM, Zhiqiang Liu wrote: > > In ext2fs_open2(), fs->image_header is assigned by calling io_channel_read_blk, > successfully. If fs->image_header->magic_number is not equal to EXT2_ET_MAGIC_E2IMAGE, > we should go to cleanup tag to free resouce and return errcode (EXT2_ET_MAGIC_E2IMAGE). > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com> > --- > lib/ext2fs/openfs.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Looks good to me. Feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com> -ritesh
Powered by blists - more mailing lists