lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Sep 2022 19:41:48 -0400 From: Gabriel Krisman Bertazi <krisman@...labora.com> To: tytso@....edu, adilger.kernel@...ger.ca, jaegeuk@...nel.org, ebiggers@...nel.org Cc: linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, Gabriel Krisman Bertazi <krisman@...labora.com>, kernel@...labora.com, Eric Biggers <ebiggers@...gle.com> Subject: [PATCH v9 6/8] ext4: Log error when lookup of encoded dentry fails If the volume is in strict mode, ext4_ci_compare can report a broken encoding name. This will not trigger on a bad lookup, which is caught earlier, only if the actual disk name is bad. Reviewed-by: Eric Biggers <ebiggers@...gle.com> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com> --- changes since v4: - Reword error message (Eric) Changes since v1: - reword error message "file in directory" -> "filename" (Eric) --- fs/ext4/namei.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 9c892c58abf2..959346950b3c 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -1452,6 +1452,9 @@ static bool ext4_match(struct inode *parent, * only case where it happens is on a disk * corruption or ENOMEM. */ + if (ret == -EINVAL) + EXT4_ERROR_INODE(parent, + "Directory contains filename that is invalid UTF-8"); return false; } return ret; -- 2.37.3
Powered by blists - more mailing lists