linux-ext4 - Re: [PATCH v3 16/16] ext4: move DIOREAD_NOLOCK setting to ext4_set_def

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220919104031.kvtf6ks2hkxp65ej@quack3>
Date:   Mon, 19 Sep 2022 12:40:31 +0200
From:   Jan Kara <jack@...e.cz>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz,
        ritesh.list@...il.com, lczerner@...hat.com,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v3 16/16] ext4: move DIOREAD_NOLOCK setting to
 ext4_set_def_opts()

On Fri 16-09-22 22:15:27, Jason Yan wrote:
> Now since all preparations is done, we can move the DIOREAD_NOLOCK
> setting to ext4_set_def_opts().
> 
> Suggested-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/super.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 25813758a53c..8624cc30c18b 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4364,6 +4364,9 @@ static void ext4_set_def_opts(struct super_block *sb,
>  	if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
>  	    ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
>  		set_opt(sb, DELALLOC);
> +
> +	if (sb->s_blocksize == PAGE_SIZE)
> +		set_opt(sb, DIOREAD_NOLOCK);
>  }
>  
>  static int ext4_handle_clustersize(struct super_block *sb)
> @@ -5109,9 +5112,6 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
>  	 */
>  	sbi->s_li_wait_mult = EXT4_DEF_LI_WAIT_MULT;
>  
> -	if (sb->s_blocksize == PAGE_SIZE)
> -		set_opt(sb, DIOREAD_NOLOCK);
> -
>  	if (ext4_inode_info_init(sb, es))
>  		goto failed_mount;
>  
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR