linux-ext4 - Re: [PATCH v2 01/18] fsdax: Wait on @page not @page->

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 11:30:55 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     akpm@...ux-foundation.org, Matthew Wilcox <willy@...radead.org>,
        Jan Kara <jack@...e.cz>, "Darrick J. Wong" <djwong@...nel.org>,
        Christoph Hellwig <hch@....de>,
        John Hubbard <jhubbard@...dia.com>,
        linux-fsdevel@...r.kernel.org, nvdimm@...ts.linux.dev,
        linux-xfs@...r.kernel.org, linux-mm@...ck.org,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2 01/18] fsdax: Wait on @page not @page->_refcount

On Thu, Sep 15, 2022 at 08:35:15PM -0700, Dan Williams wrote:
> The __wait_var_event facility calculates a wait queue from a hash of the
> address of the variable being passed. Use the @page argument directly as
> it is less to type and is the object that is being waited upon.
> 
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Jan Kara <jack@...e.cz>
> Cc: "Darrick J. Wong" <djwong@...nel.org>
> Cc: Jason Gunthorpe <jgg@...dia.com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: John Hubbard <jhubbard@...dia.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
>  fs/ext4/inode.c   |    8 ++++----
>  fs/fuse/dax.c     |    6 +++---
>  fs/xfs/xfs_file.c |    6 +++---
>  mm/memremap.c     |    2 +-
>  4 files changed, 11 insertions(+), 11 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason