linux-ext4 - Re: [PATCHv3 0/4] submit_bh: Drop unnecessary return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166446350046.149484.7882160010010426978.b4-ty@mit.edu>
Date:   Thu, 29 Sep 2022 10:58:27 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     ritesh.list@...il.com, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Cc:     "Theodore Ts'o" <tytso@....edu>,
        linux-ntfs-dev@...ts.sourceforge.net,
        Christoph Hellwig <hch@....de>, jack@...e.com,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCHv3 0/4] submit_bh: Drop unnecessary return value

On Thu, 18 Aug 2022 10:34:36 +0530, Ritesh Harjani (IBM) wrote:
> submit_bh/submit_bh_wbc are non-blocking functions which just submits
> the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait
> on buffer till I/O completion and then check buffer head's b_state field
> to know if there was any I/O error.
> 
> Hence there is no need for these functions to have any return type.
> Even now they always returns 0. Hence drop the return value and make
> their return type as void to avoid any confusion.
> 
> [...]

Applied, thanks!

[1/4] jbd2: Drop useless return value of submit_bh
      commit: c2939da1fe8b25c82c1991eb983638463ed84a0c
[2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read
      commit: f102f1ab784c91c559a3505d024008ff2decc77f
[3/4] fs/buffer: Drop useless return value of submit_bh
      commit: 7cb83d3c0c485b3b035cdcac4c6ef4937f920c59
[4/4] fs/buffer: Make submit_bh & submit_bh_wbc return type as void
      commit: 54a55bcabb92f7522e006ca38575159c41914c56

Best regards,
-- 
Theodore Ts'o <tytso@....edu>