linux-ext4 - Re: [PATCH][next] ext4: remove unused string "deprecated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Oct 2022 22:49:18 +0530
From:   Ojaswin Mujoo <ojaswin@...ux.ibm.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ext4: remove unused string "deprecated_msg"

On Tue, Oct 04, 2022 at 12:21:14PM +0100, Colin Ian King wrote:
> The string deprecated_msg is no longer being used, remove it.

So if IIUC we use this string as a standard message whenever we use any
mount options about to be deprecated. We don't seem to have any
deprecated mount options right now but we might want to keep the string
around for future?

> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  fs/ext4/super.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 2335452efed0..981563c8245e 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1740,10 +1740,6 @@ static const struct fs_parameter_spec ext4_param_specs[] = {
>  
>  #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))
>  
> -static const char deprecated_msg[] =
> -	"Mount option \"%s\" will be removed by %s\n"
> -	"Contact linux-ext4@...r.kernel.org if you think we should keep it.\n";
> -
>  #define MOPT_SET	0x0001
>  #define MOPT_CLEAR	0x0002
>  #define MOPT_NOSUPPORT	0x0004
> -- 
> 2.37.1
>