linux-ext4 - Re: [bug report] misc/fsck.c: Processes may kill other processes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 17:26:49 +0800
From:   zhanchengbin <zhanchengbin1@...wei.com>
To:     Karel Zak <kzak@...hat.com>, Lukas Czerner <lczerner@...hat.com>
CC:     Theodore Ts'o <tytso@....edu>, <linux-ext4@...r.kernel.org>,
        <liuzhiqiang26@...wei.com>, linfeilong <linfeilong@...wei.com>
Subject: Re: [bug report] misc/fsck.c: Processes may kill other processes.



在 2022/10/10 16:09, Karel Zak 写道:
> On Fri, Sep 30, 2022 at 09:20:42AM +0200, Lukas Czerner wrote:
>> On Fri, Sep 30, 2022 at 09:42:52AM +0800, zhanchengbin wrote:
>>>
>>>
>>> On 2022/9/29 19:28, Lukas Czerner wrote:
>>>> Hi,
>>>>
>>>> indeed we'd like to avoid killing the instance that was not ran because
>>>> of noexecute. Can you try the following patch?
>>>>
>>>> Thanks!
>>>> -Lukas
>>>
>>> Yes, you're right, I think we can fix it in this way.
>>>
>>> diff --git a/misc/fsck.c b/misc/fsck.c
>>> index 1f6ec7d9..91edbf17 100644
>>> --- a/misc/fsck.c
>>> +++ b/misc/fsck.c
>>> @@ -547,6 +547,8 @@ static int kill_all(int signum)
>>>          for (inst = instance_list; inst; inst = inst->next) {
>>>                  if (inst->flags & FLAG_DONE)
>>>                          continue;
>>> +               if (inst->pid == -1)
>>> +                       continue;
>>
>> Yeah, that works as well although I find the "if (noexecute)" condition
>> more obvious. We can do both. Also rather than checking for -1 we can
>> check for <= 0 since anything other than real pid at this point is a bug.
>>
>> Feel free to send a proper patch.
> 
> Yes, please. It would be nice to have the same solution in the both
> (e2fsprogs and util-linux) trees.

Ok, I have sent the patch, please review it.

  -zhanchengbin
> 
>      Karel
>