linux-ext4 - Re: [PATCH] tune2fs: exit directly when fs freed in ext2fs_run_ext3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1GAfCVhruEJ+5IL@mit.edu>
Date:   Thu, 20 Oct 2022 13:08:12 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Li Jinlin <lijinlin3@...wei.com>
Cc:     adilger@...mcloud.com, linux-ext4@...r.kernel.org,
        linfeilong@...wei.com, liuzhiqiang26@...wei.com
Subject: Re: [PATCH] tune2fs: exit directly when fs freed in
 ext2fs_run_ext3_journal

On Fri, Sep 16, 2022 at 03:42:23PM +0800, Li Jinlin wrote:
> In ext2fs_run_ext3_journal(), fs will be free and reallocate. But
> reallocating by ext2fs_open() may fail in some cases, such as device
> being offline at the same time. In these cases, goto closefs will
> cause segfault, fix it by exiting directly.
> 
> Signed-off-by: Li Jinlin <lijinlin3@...wei.com>

Thanks, applied, although I simplified the patch a little:

@@ -3106,6 +3106,8 @@ _("Warning: The journal is dirty. You may wish to replay the journal like:\n\n"
                        com_err("tune2fs", retval,
                                "while recovering journal.\n");
                        printf(_("Please run e2fsck -fy %s.\n"), argv[1]);
+                       if (!fs)
+                               exit(1);
                        rc = 1;
                        goto closefs;
                }

					- Ted