linux-ext4 - Re: [e2fsprogs PATCH] e2fsck: don't allow journal inode to have encrypt flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2LqExmYPBIOypW0@sol.localdomain>
Date:   Wed, 2 Nov 2022 15:07:15 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     linux-ext4@...r.kernel.org, linux-fscrypt@...r.kernel.org
Subject: Re: [e2fsprogs PATCH] e2fsck: don't allow journal inode to have
 encrypt flag

On Wed, Nov 02, 2022 at 02:55:05PM -0600, Andreas Dilger wrote:
> On Nov 1, 2022, at 11:35 PM, Eric Biggers <ebiggers@...nel.org> wrote:
> > 
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > Since the kernel is being fixed to consider journal inodes with the
> > 'encrypt' flag set to be invalid, also update e2fsck accordingly.
> > 
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> > ---
> > e2fsck/journal.c                   |   3 ++-
> > tests/f_badjour_encrypted/expect.1 |  30 +++++++++++++++++++++++++++++
> > tests/f_badjour_encrypted/expect.2 |   7 +++++++
> > tests/f_badjour_encrypted/image.gz | Bin 0 -> 2637 bytes
> 
> Good to have a test case for this.
> 
> In the past Ted has asked that new test cases are generated via mke2fs
> and debugfs in "f_XXX/script" file rather than a binary image, if possible.

I didn't realize the test suite supported this.  Done in v2, thanks!

- Eric