lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Nov 2022 07:18:17 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Steven Rostedt <rostedt@...dmis.org> Cc: linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Thomas Gleixner <tglx@...utronix.de>, Stephen Boyd <sboyd@...nel.org>, Anna-Maria Gleixner <anna-maria@...utronix.de>, Andrew Morton <akpm@...ux-foundation.org>, rcu@...r.kernel.org, linux-doc@...r.kernel.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, linux-edac@...r.kernel.org, cgroups@...r.kernel.org, linux-block@...r.kernel.org, linux-acpi@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-pm@...r.kernel.org, drbd-dev@...ts.linbit.com, linux-bluetooth@...r.kernel.org, openipmi-developer@...ts.sourceforge.net, linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org, intel-gfx@...ts.freedesktop.org, linux-input@...r.kernel.org, linux-parisc@...r.kernel.org, linux-leds@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, linux-usb@...r.kernel.org, linux-wireless@...r.kernel.org, linux-scsi@...r.kernel.org, linux-staging@...ts.linux.dev, linux-ext4@...r.kernel.org, linux-nilfs@...r.kernel.org, bridge@...ts.linux-foundation.org, netfilter-devel@...r.kernel.org, coreteam@...filter.org, lvs-devel@...r.kernel.org, linux-afs@...ts.infradead.org, linux-nfs@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, alsa-devel@...a-project.org Subject: Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers On Sat, Nov 05, 2022 at 02:00:24AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit was. I got side tracked and never finished up on that patch set. > Since this type of crash is still our #1 crash we are seeing in the field, > it has become a priority again to finish it. > > The last version of that patch set is here: > > https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ > > I'm calling this version 4a as it only has obvious changes were the timer that > is being shutdown is in the same function where it will be freed or released, > as this series should be "safe" for adding. I'll be calling the other patches > 4b for the next merge window. > Just in case you didn't notice: Looking through the resulting code, I think some of the remaining calls to del_singleshot_timer_sync() can be converted as well. The calls in drivers/staging/wlan-ng/prism2usb.c:prism2sta_disconnect_usb() are obvious (the containing data structure is freed in the same function). For drivers/char/tpm/tpm-dev-common.c:tpm_common_release(), the containing data structure is freed in the calling code. Thanks, Guenter
Powered by blists - more mailing lists