linux-ext4 - Re: [PATCH v2] ext4: fix wrong return err in ext4_load_and_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166771539910.127460.2313968809841911803.b4-ty@mit.edu>
Date:   Sun,  6 Nov 2022 01:16:52 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     jack@...e.cz, lczerner@...hat.com, linux-ext4@...r.kernel.org,
        ritesh.list@...il.com, Jason Yan <yanaijie@...wei.com>,
        adilger.kernel@...ger.ca
Cc:     "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH v2] ext4: fix wrong return err in ext4_load_and_init_journal()

On Tue, 25 Oct 2022 12:02:06 +0800, Jason Yan wrote:
> The return value is wrong in ext4_load_and_init_journal(). The local
> variable 'err' need to be initialized before goto out. The original code
> in __ext4_fill_super() is fine because it has two return values 'ret'
> and 'err' and 'ret' is initialized as -EINVAL. After we factor out
> ext4_load_and_init_journal(), this code is broken. So fix it by directly
> returning -EINVAL in the error handler path.
> 
> [...]

Applied, thanks!

[1/1] ext4: fix wrong return err in ext4_load_and_init_journal()
      commit: 9f2a1d9fb33a2129a9ba29bc61d3f14adb28ddc2

Best regards,
-- 
Theodore Ts'o <tytso@....edu>