linux-ext4 - configurable lazytime for EXT4, is name ok?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <173aa5e092bc4f3a8a49be9c095a7d6e@amazon.com>
Date:   Tue, 8 Nov 2022 00:51:47 +0000
From:   "Lu, Davina" <davinalu@...zon.com>
To:     Theodore Ts'o <tytso@....edu>
CC:     "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Mohamed Abuelfotoh, Hazem" <abuehaze@...zon.com>,
        hazem ahmed mohamed <hazem.ahmed.abuelfotoh@...il.com>,
        "Ritesh Harjani (IBM)" <ritesh.list@...il.com>,
        "Kiselev, Oleg" <okiselev@...zon.com>,
        "Liu, Frank" <franklmz@...zon.com>
Subject: configurable lazytime for EXT4, is name ok?

Hi Ted,

Sorry to bother you with a quick question: I am doing a patch for configurable lazytime for EXT4, Before submit the patch I would like to double check the names first. I added a "lazytime_flush=xxx" in mount show options, not sure if this is ok to continue. 

As far as I know, lazytime is an option for EXT4 and other file systems. My patch make ext4 can be supported as before: without any parameters E.g. mount -o lazytime,... 
Or can be supported with parameters (in ms) E.g. mount -o lazytime=30, ... 

So when we show the options by mount -t ext4, if no parameter configured, the result shows as before:
/dev/nvme1n1 on /rdsdbdata1 type ext4 (rw,noatime,nodiratime,lazytime,data=ordered)

If has parameters configured, the result shows as below, added one "lazytime_flush=xxx". Not sure if this sound ok for you? 
/dev/nvme1n1 on /rdsdbdata1 type ext4 (rw,noatime,nodiratime,lazytime,lazytime_flush=100ms,data=ordered)

I tested "ext4/053"of latest xfstest-dev with my patch and it can pass the result(I changed a bit 053 since I am running on 5.10, removed one mount option" no_prefetch_block_bitmaps" that  5.10 doesn't support).

Thanks
Davina