[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 Nov 2022 20:10:27 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: <snitzer@...nel.org>, <Martin.Wilck@...e.com>, <ejt@...hat.com>,
<jack@...e.cz>, <tytso@....edu>, <yi.zhang@...wei.com>,
<chengzhihao1@...wei.com>
CC: <dm-devel@...hat.com>, <linux-ext4@...r.kernel.org>
Subject: [dm-devel] [PATCH 1/3] dm bufio: Fix missing decrement of no_sleep_enabled if dm_bufio_client_create failed
The 'no_sleep_enabled' should be decreased in error handling path
in dm_bufio_client_create() when flag DM_BUFIO_CLIENT_NO_SLEEP is
set, otherwise static_branch_unlikely() will always return true
even no dm_bufio_client instances has DM_BUFIO_CLIENT_NO_SLEEP flag.
Fixes: 3c1c875d0586 ("dm bufio: conditionally enable branching for DM_BUFIO_CLIENT_NO_SLEEP")
Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>
---
drivers/md/dm-bufio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
index 9c5ef818ca36..bb786c39545e 100644
--- a/drivers/md/dm-bufio.c
+++ b/drivers/md/dm-bufio.c
@@ -1858,6 +1858,8 @@ struct dm_bufio_client *dm_bufio_client_create(struct block_device *bdev, unsign
dm_io_client_destroy(c->dm_io);
bad_dm_io:
mutex_destroy(&c->lock);
+ if (c->no_sleep)
+ static_branch_dec(&no_sleep_enabled);
kfree(c);
bad_client:
return ERR_PTR(r);
--
2.31.1
Powered by blists - more mailing lists