linux-ext4 - Re: [PATCH 2/9] ext2: remove ->writepage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221114104927.k5x4i4uanxskfs6m@quack3>
Date:   Mon, 14 Nov 2022 11:49:27 +0100
From:   Jan Kara <jack@...e.cz>
To:     Christoph Hellwig <hch@....de>
Cc:     Namjae Jeon <linkinjeon@...nel.org>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        Jan Kara <jack@...e.com>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
        Dave Kleikamp <shaggy@...nel.org>,
        Bob Copeland <me@...copeland.com>,
        linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
        jfs-discussion@...ts.sourceforge.net,
        linux-karma-devel@...ts.sourceforge.net, linux-mm@...ck.org
Subject: Re: [PATCH 2/9] ext2: remove ->writepage

On Sun 13-11-22 17:28:55, Christoph Hellwig wrote:
> ->writepage is a very inefficient method to write back data, and only
> used through write_cache_pages or a a fallback when no ->migrate_folio
> method is present.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Looks good! Feel free to add:

Acked-by: Jan Kara <jack@...e.cz>

								Honza
> ---
>  fs/ext2/inode.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 918ab2f9e4c05..3b2e3e1e0fa25 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -869,11 +869,6 @@ int ext2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
>  	return ret;
>  }
>  
> -static int ext2_writepage(struct page *page, struct writeback_control *wbc)
> -{
> -	return block_write_full_page(page, ext2_get_block, wbc);
> -}
> -
>  static int ext2_read_folio(struct file *file, struct folio *folio)
>  {
>  	return mpage_read_folio(folio, ext2_get_block);
> @@ -948,7 +943,6 @@ const struct address_space_operations ext2_aops = {
>  	.invalidate_folio	= block_invalidate_folio,
>  	.read_folio		= ext2_read_folio,
>  	.readahead		= ext2_readahead,
> -	.writepage		= ext2_writepage,
>  	.write_begin		= ext2_write_begin,
>  	.write_end		= ext2_write_end,
>  	.bmap			= ext2_bmap,
> -- 
> 2.30.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR