linux-ext4 - Re: [PATCH 7/9] jfs: remove ->writepage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2022 08:29:04 -0600
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Christoph Hellwig <hch@....de>,
        Namjae Jeon <linkinjeon@...nel.org>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        Jan Kara <jack@...e.com>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
        Bob Copeland <me@...copeland.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
        jfs-discussion@...ts.sourceforge.net,
        linux-karma-devel@...ts.sourceforge.net, linux-mm@...ck.org
Subject: Re: [PATCH 7/9] jfs: remove ->writepage

On 11/13/22 10:29AM, Christoph Hellwig wrote:
> ->writepage is a very inefficient method to write back data, and only
> used through write_cache_pages or a a fallback when no ->migrate_folio
> method is present.
> 
> Set ->migrate_folio to the generic buffer_head based helper, and remove
> the ->writepage implementation.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Acked-by: Dave Kleikamp <dave.kleikamp@...cle.com>

> ---
>   fs/jfs/inode.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
> index d1ec920aa030a..8ac10e3960508 100644
> --- a/fs/jfs/inode.c
> +++ b/fs/jfs/inode.c
> @@ -264,11 +264,6 @@ int jfs_get_block(struct inode *ip, sector_t lblock,
>   	return rc;
>   }
>   
> -static int jfs_writepage(struct page *page, struct writeback_control *wbc)
> -{
> -	return block_write_full_page(page, jfs_get_block, wbc);
> -}
> -
>   static int jfs_writepages(struct address_space *mapping,
>   			struct writeback_control *wbc)
>   {
> @@ -355,12 +350,12 @@ const struct address_space_operations jfs_aops = {
>   	.invalidate_folio = block_invalidate_folio,
>   	.read_folio	= jfs_read_folio,
>   	.readahead	= jfs_readahead,
> -	.writepage	= jfs_writepage,
>   	.writepages	= jfs_writepages,
>   	.write_begin	= jfs_write_begin,
>   	.write_end	= jfs_write_end,
>   	.bmap		= jfs_bmap,
>   	.direct_IO	= jfs_direct_IO,
> +	.migrate_folio	= buffer_migrate_folio,
>   };
>   
>   /*