linux-ext4 - Re: [RFCv1 04/72] badblocks: Remove unused badblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2022 07:26:45 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     "Ritesh Harjani (IBM)" <ritesh.list@...il.com>
Cc:     Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org,
        Harshad Shirwadkar <harshadshirwadkar@...il.com>,
        Wang Shilong <wshilong@....com>,
        Andreas Dilger <adilger.kernel@...ger.ca>, Li Xi <lixi@....com>
Subject: Re: [RFCv1 04/72] badblocks: Remove unused badblocks_flags

On Nov 7, 2022, at 06:22, Ritesh Harjani (IBM) <ritesh.list@...il.com> wrote:
> 
> badblocks_flags is not used anywhere. So just remove it.
> 
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> lib/ext2fs/badblocks.c | 6 +-----
> lib/ext2fs/ext2fsP.h   | 1 -
> 2 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/lib/ext2fs/badblocks.c b/lib/ext2fs/badblocks.c
> index a306bc06..345168e0 100644
> --- a/lib/ext2fs/badblocks.c
> +++ b/lib/ext2fs/badblocks.c
> @@ -81,11 +81,7 @@ errcode_t ext2fs_u32_copy(ext2_u32_list src, ext2_u32_list *dest)
> {
>    errcode_t    retval;
> 
> -    retval = make_u32_list(src->size, src->num, src->list, dest);
> -    if (retval)
> -        return retval;
> -    (*dest)->badblocks_flags = src->badblocks_flags;
> -    return 0;
> +    return make_u32_list(src->size, src->num, src->list, dest);
> }
> 
> errcode_t ext2fs_badblocks_copy(ext2_badblocks_list src,
> diff --git a/lib/ext2fs/ext2fsP.h b/lib/ext2fs/ext2fsP.h
> index a20a0502..d2045af8 100644
> --- a/lib/ext2fs/ext2fsP.h
> +++ b/lib/ext2fs/ext2fsP.h
> @@ -34,7 +34,6 @@ struct ext2_struct_u32_list {
>    int    num;
>    int    size;
>    __u32    *list;
> -    int    badblocks_flags;
> };
> 
> struct ext2_struct_u32_iterate {
> -- 
> 2.37.3
>