linux-ext4 - Re: [syzbot] possible deadlock in jbd2_journal_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221121154048.iccqmx7zajhxh4aq@quack3>
Date:   Mon, 21 Nov 2022 16:40:48 +0100
From:   Jan Kara <jack@...e.cz>
To:     Thorsten Leemhuis <regressions@...mhuis.info>
Cc:     Jan Kara <jack@...e.cz>,
        Jeremi Piotrowski <jpiotrowski@...ux.microsoft.com>,
        Thilo Fromm <t-lo@...ux.microsoft.com>,
        Ye Bin <yebin10@...wei.com>, jack@...e.com, tytso@....edu,
        linux-ext4@...r.kernel.org, regressions@...ts.linux.dev
Subject: Re: [syzbot] possible deadlock in jbd2_journal_lock_updates

On Mon 21-11-22 16:18:09, Thorsten Leemhuis wrote:
> On 21.11.22 16:00, Jan Kara wrote:
> > OK, attached patch fixes the deadlock for me. Can you test whether it fixes
> > the problem for you as well? Thanks!
> 
> Jan, many thx for taking care of this. There is one small thing to
> improve, please add the following tags to your patch:
> 
> Link:
> https://lore.kernel.org/r/c77bf00f-4618-7149-56f1-b8d1664b9d07@linux.microsoft.com/
 
Good point. Thanks, added!

> Not sure, maybe a reported-by for Syzbot would be good as well, see:
> https://lore.kernel.org/linux-ext4/000000000000892a3005e5b5d96c@google.com/

The syzbot report is actually unrelated. So far I think that the bisection
that landed guys on the same commit as syzbot was just luck or maybe change
in timing that made the problem easier to reproduce. 

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR