linux-ext4 - Re: [PATCH] fs/ext2: Fix code indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2022 11:17:59 +0100
From:   Jan Kara <jack@...e.cz>
To:     Rong Tao <rtoax@...mail.com>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rong Tao <rongtao@...tc.cn>
Subject: Re: [PATCH] fs/ext2: Fix code indentation

On Fri 25-11-22 21:38:21, Rong Tao wrote:
> From: Rong Tao <rongtao@...tc.cn>
> 
> ts=4 can cause misunderstanding in code reading. It is better to replace
> 8 spaces with one tab.
> 
> Signed-off-by: Rong Tao <rongtao@...tc.cn>

Thanks for the cleanup! When doing whitespace cleanup like this, can you
please also fix another 5 lines in fs/ext2/balloc.c which have this problem
and submit it as a single patch together with this? Thanks!

								Honza

> ---
>  fs/ext2/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 03f2af98b1b4..69c88facfe90 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1648,7 +1648,7 @@ static int __init init_ext2_fs(void)
>  	err = init_inodecache();
>  	if (err)
>  		return err;
> -        err = register_filesystem(&ext2_fs_type);
> +	err = register_filesystem(&ext2_fs_type);
>  	if (err)
>  		goto out;
>  	return 0;
> -- 
> 2.31.1
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR