lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221201091442.flpoeo7s4yknmtwy@riteshh-domain> Date: Thu, 1 Dec 2022 14:44:42 +0530 From: "Ritesh Harjani (IBM)" <ritesh.list@...il.com> To: Jan Kara <jack@...e.cz> Cc: Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org, Christoph Hellwig <hch@...radead.org> Subject: Re: [PATCH 3/9] ext4: Remove nr_submitted from ext4_bio_write_page() On 22/11/30 05:35PM, Jan Kara wrote: > nr_submitted is the same as nr_to_submit. Drop one of them. Yup. Since we are not calling end_page_writeback() anymore. So we don't require nr_submitted too. Looks good to me. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com> > > Signed-off-by: Jan Kara <jack@...e.cz> > --- > fs/ext4/page-io.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index 4f9ecacd10aa..2bdfb8a046d9 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -437,7 +437,6 @@ int ext4_bio_write_page(struct ext4_io_submit *io, > unsigned block_start; > struct buffer_head *bh, *head; > int ret = 0; > - int nr_submitted = 0; > int nr_to_submit = 0; > struct writeback_control *wbc = io->io_wbc; > bool keep_towrite = false; > @@ -566,7 +565,6 @@ int ext4_bio_write_page(struct ext4_io_submit *io, > continue; > io_submit_add_bh(io, inode, > bounce_page ? bounce_page : page, bh); > - nr_submitted++; > } while ((bh = bh->b_this_page) != head); > unlock: > unlock_page(page); > -- > 2.35.3 >
Powered by blists - more mailing lists