linux-ext4 - Re: [PATCH v2 9/11] ext4: Switch to using write_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4xFAk0ILz70ZtVW@infradead.org>
Date:   Sat, 3 Dec 2022 22:58:10 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Jan Kara <jack@...e.cz>
Cc:     Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        Ritesh Harjani <ritesh.list@...il.com>
Subject: Re: [PATCH v2 9/11] ext4: Switch to using write_cache_pages() for
 data=journal writeout

> +static int __writepage(struct page *page, struct writeback_control *wbc,
> +		       void *data)

Can we give this a somewhat more descriptive name, e.g.
ext4_writepage_cb or so?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>