linux-ext4 - Re: [PATCH v2 1/11] ext4: Remove ordered data support from ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4xHB+fDxyfOCwu5@infradead.org>
Date:   Sat, 3 Dec 2022 23:06:47 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Jan Kara <jack@...e.cz>
Cc:     Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        Ritesh Harjani <ritesh.list@...il.com>
Subject: Re: [PATCH v2 1/11] ext4: Remove ordered data support from
 ext4_writepage()

> + * This function is now used only when journaling data. We cannot start
> + * transaction directly because transaction start ranks above page lock so we
> + * have to do some magic.
>   */
> +static int ext4_writepage(struct page *page, struct writeback_control *wbc,
> +			  void *data)

Maybe call this ext4_journalled_writepage now to make the limitation
more clear?  And/or fold __ext4_journalled_writepage into while we're
at it.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>