linux-ext4 - Re: [PATCH] ext4: don't allow journal inode to have encrypt flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <167036049593.156498.14603526492088665546.b4-ty@mit.edu>
Date:   Tue,  6 Dec 2022 16:01:48 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Eric Biggers <ebiggers@...nel.org>, linux-ext4@...r.kernel.org
Cc:     "Theodore Ts'o" <tytso@....edu>,
        syzbot+ba9dac45bc76c490b7c3@...kaller.appspotmail.com,
        linux-fscrypt@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ext4: don't allow journal inode to have encrypt flag

On Tue, 1 Nov 2022 22:33:12 -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Mounting a filesystem whose journal inode has the encrypt flag causes a
> NULL dereference in fscrypt_limit_io_blocks() when the 'inlinecrypt'
> mount option is used.
> 
> The problem is that when jbd2_journal_init_inode() calls bmap(), it
> eventually finds its way into ext4_iomap_begin(), which calls
> fscrypt_limit_io_blocks().  fscrypt_limit_io_blocks() requires that if
> the inode is encrypted, then its encryption key must already be set up.
> That's not the case here, since the journal inode is never "opened" like
> a normal file would be.  Hence the crash.
> 
> [...]

Applied, thanks!

[1/1] ext4: don't allow journal inode to have encrypt flag
      commit: 29cef51d8522c4d8953856afaffcaf1b754e4f6c

Best regards,
-- 
Theodore Ts'o <tytso@....edu>