lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Dec 2022 14:03:57 +0800 From: Chao Yu <chao@...nel.org> To: "Vishal Moola (Oracle)" <vishal.moola@...il.com>, linux-fsdevel@...r.kernel.org Cc: linux-cifs@...r.kernel.org, linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, cluster-devel@...hat.com, linux-mm@...ck.org, ceph-devel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-afs@...ts.infradead.org, linux-btrfs@...r.kernel.org Subject: Re: [f2fs-dev] [PATCH v4 16/23] f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() On 2022/11/3 0:10, Vishal Moola (Oracle) wrote: > Convert function to use folios throughout. This is in preparation for the > removal of find_get_pages_range_tag(). This change removes 5 calls to > compound_head(). > > Initially the function was checking if the previous page index is truly the > previous page i.e. 1 index behind the current page. To convert to folios and > maintain this check we need to make the check > folio->index != prev + folio_nr_pages(previous folio) since we don't know > how many pages are in a folio. > > At index i == 0 the check is guaranteed to succeed, so to workaround indexing > bounds we can simply ignore the check for that specific index. This makes the > initial assignment of prev trivial, so I removed that as well. > > Also modified a comment in commit_checkpoint for consistency. > > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@...il.com> Acked-by: Chao Yu <chao@...nel.org> Thanks,
Powered by blists - more mailing lists