lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Dec 2022 22:05:05 +0100 From: Andreas Grünbacher <andreas.gruenbacher@...il.com> To: Christoph Hellwig <hch@...radead.org> Cc: Andreas Gruenbacher <agruenba@...hat.com>, "Darrick J . Wong" <djwong@...nel.org>, Alexander Viro <viro@...iv.linux.org.uk>, Matthew Wilcox <willy@...radead.org>, linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, cluster-devel@...hat.com Subject: Re: [RFC v3 4/7] iomap: Add iomap_folio_prepare helper Am Fr., 23. Dez. 2022 um 16:22 Uhr schrieb Christoph Hellwig <hch@...radead.org>: > > +struct folio *iomap_folio_prepare(struct iomap_iter *iter, loff_t pos) > > +{ > > + unsigned fgp = FGP_LOCK | FGP_WRITE | FGP_CREAT | FGP_STABLE | FGP_NOFS; > > + > > + if (iter->flags & IOMAP_NOWAIT) > > + fgp |= FGP_NOWAIT; > > + > > + return __filemap_get_folio(iter->inode->i_mapping, pos >> PAGE_SHIFT, > > + fgp, mapping_gfp_mask(iter->inode->i_mapping)); > > +} > > +EXPORT_SYMBOL(iomap_folio_prepare); > > I'd name this __iomap_get_folio to match __filemap_get_folio. I was looking at it from the filesystem point of view: this helper is meant to be used in ->folio_prepare() handlers, so iomap_folio_prepare() seemed to be a better name than __iomap_get_folio(). > And all iomap exports are EXPORT_SYMBOL_GPL. Sure. Thanks, Andreas
Powered by blists - more mailing lists