linux-ext4 - Re: [e2fsprogs PATCH] resize2fs: remove unused variable from adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230104103543.bzdpmz4iy7flpmdi@fedora>
Date:   Wed, 4 Jan 2023 11:35:43 +0100
From:   Lukas Czerner <lczerner@...hat.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [e2fsprogs PATCH] resize2fs: remove unused variable from
 adjust_superblock()

On Wed, Jan 04, 2023 at 01:03:51AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> In adjust_superblock(), the 'group_block' variable is declared and set,
> but it is never actually used.  Remove it.
> 
> This addresses the following compiler warning with clang -Wall:
> 
> resize2fs.c:1119:11: warning: variable 'group_block' set but not used [-Wunused-but-set-variable]
>         blk64_t         group_block;

Looks good thanks.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

>                         ^
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>  resize/resize2fs.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/resize/resize2fs.c b/resize/resize2fs.c
> index 243cd777..5eeb7d44 100644
> --- a/resize/resize2fs.c
> +++ b/resize/resize2fs.c
> @@ -1116,7 +1116,6 @@ static errcode_t adjust_superblock(ext2_resize_t rfs, blk64_t new_size)
>  	ext2_filsys	fs = rfs->new_fs;
>  	int		adj = 0;
>  	errcode_t	retval;
> -	blk64_t		group_block;
>  	unsigned long	i;
>  	unsigned long	max_group;
>  
> @@ -1181,8 +1180,6 @@ static errcode_t adjust_superblock(ext2_resize_t rfs, blk64_t new_size)
>  		goto errout;
>  
>  	memset(rfs->itable_buf, 0, fs->blocksize * fs->inode_blocks_per_group);
> -	group_block = ext2fs_group_first_block2(fs,
> -						rfs->old_fs->group_desc_count);
>  	adj = rfs->old_fs->group_desc_count;
>  	max_group = fs->group_desc_count - adj;
>  	if (rfs->progress) {
> @@ -1209,7 +1206,6 @@ static errcode_t adjust_superblock(ext2_resize_t rfs, blk64_t new_size)
>  			if (retval)
>  				goto errout;
>  		}
> -		group_block += fs->super->s_blocks_per_group;
>  	}
>  	io_channel_flush(fs->io);
>  	retval = 0;
> -- 
> 2.39.0
>