linux-ext4 - Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8b24129-536c-a367-1436-fe0e054259cf@omp.ru>
Date:   Mon, 9 Jan 2023 12:10:15 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Byungchul Park <byungchul.park@....com>,
        <linux-kernel@...r.kernel.org>
CC:     <torvalds@...ux-foundation.org>,
        <damien.lemoal@...nsource.wdc.com>, <linux-ide@...r.kernel.org>,
        <adilger.kernel@...ger.ca>, <linux-ext4@...r.kernel.org>,
        <mingo@...hat.com>, <peterz@...radead.org>, <will@...nel.org>,
        <tglx@...utronix.de>, <rostedt@...dmis.org>,
        <joel@...lfernandes.org>, <sashal@...nel.org>,
        <daniel.vetter@...ll.ch>, <duyuyang@...il.com>,
        <johannes.berg@...el.com>, <tj@...nel.org>, <tytso@....edu>,
        <willy@...radead.org>, <david@...morbit.com>, <amir73il@...il.com>,
        <gregkh@...uxfoundation.org>, <kernel-team@....com>,
        <linux-mm@...ck.org>, <akpm@...ux-foundation.org>,
        <mhocko@...nel.org>, <minchan@...nel.org>, <hannes@...xchg.org>,
        <vdavydov.dev@...il.com>, <sj@...nel.org>, <jglisse@...hat.com>,
        <dennis@...nel.org>, <cl@...ux.com>, <penberg@...nel.org>,
        <rientjes@...gle.com>, <vbabka@...e.cz>, <ngupta@...are.org>,
        <linux-block@...r.kernel.org>, <paolo.valente@...aro.org>,
        <josef@...icpanda.com>, <linux-fsdevel@...r.kernel.org>,
        <viro@...iv.linux.org.uk>, <jack@...e.cz>, <jlayton@...nel.org>,
        <dan.j.williams@...el.com>, <hch@...radead.org>,
        <djwong@...nel.org>, <dri-devel@...ts.freedesktop.org>,
        <rodrigosiqueiramelo@...il.com>, <melissa.srw@...il.com>,
        <hamohammed.sa@...il.com>, <42.hyeyoo@...il.com>,
        <chris.p.wilson@...el.com>, <gwan-gyeong.mun@...el.com>
Subject: Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to
 PG_{locked,writeback} wait

On 1/9/23 6:33 AM, Byungchul Park wrote:

> Makes Dept able to track dependencies by PG_{locked,writeback} waits.
> 
> Signed-off-by: Byungchul Park <byungchul.park@....com>
> ---
>  mm/filemap.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index c4d4ace..b013a5b 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
[...]
> @@ -1226,6 +1230,11 @@ static inline int folio_wait_bit_common(struct folio *folio, int bit_nr,
>  	unsigned long pflags;
>  	bool in_thrashing;
>  
> +	if (bit_nr == PG_locked)
> +		sdt_might_sleep_strong(&PG_locked_map);
> +	else if (bit_nr == PG_writeback)
> +		sdt_might_sleep_strong(&PG_writeback_map);

   Hm, this is asking to be a *switch* statement instead...

[...]

MBR, Sergey