linux-ext4 - Re: [PATCH 3/7] ext4: Mark page for delayed dirtying only if it is pinned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2023 10:07:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jan Kara <jack@...e.cz>, Ted Tso <tytso@....edu>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 3/7] ext4: Mark page for delayed dirtying only if it is
 pinned

Hi Jan,

I love your patch! Yet something to improve:

[auto build test ERROR on tytso-ext4/dev]
[also build test ERROR on linus/master v6.2-rc3 next-20230111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jan-Kara/ext4-Update-stale-comment-about-write-constraints/20230111-234837
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
patch link:    https://lore.kernel.org/r/20230111154338.392-3-jack%40suse.cz
patch subject: [PATCH 3/7] ext4: Mark page for delayed dirtying only if it is pinned
config: i386-randconfig-a013
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d96cf5a515c2cfae084227d197c80e53683c1cf8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jan-Kara/ext4-Update-stale-comment-about-write-constraints/20230111-234837
        git checkout d96cf5a515c2cfae084227d197c80e53683c1cf8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> fs/ext4/inode.c:3691:6: error: implicit declaration of function 'folio_may_be_dma_pinned' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           if (folio_may_be_dma_pinned(folio))
               ^
   fs/ext4/inode.c:3691:6: note: did you mean 'folio_maybe_dma_pinned'?
   include/linux/mm.h:1562:20: note: 'folio_maybe_dma_pinned' declared here
   static inline bool folio_maybe_dma_pinned(struct folio *folio)
                      ^
   1 error generated.


vim +/folio_may_be_dma_pinned +3691 fs/ext4/inode.c

  3671	
  3672	/*
  3673	 * For data=journal mode, folio should be marked dirty only when it was
  3674	 * writeably mapped. When that happens, it was already attached to the
  3675	 * transaction and marked as jbddirty (we take care of this in
  3676	 * ext4_page_mkwrite()). On transaction commit, we writeprotect page mappings
  3677	 * so we should have nothing to do here, except for the case when someone
  3678	 * had the page pinned and dirtied the page through this pin (e.g. by doing
  3679	 * direct IO to it). In that case we'd need to attach buffers here to the
  3680	 * transaction but we cannot due to lock ordering.  We cannot just dirty the
  3681	 * folio and leave attached buffers clean, because the buffers' dirty state is
  3682	 * "definitive".  We cannot just set the buffers dirty or jbddirty because all
  3683	 * the journalling code will explode.  So what we do is to mark the folio
  3684	 * "pending dirty" and next time ext4_writepages() is called, attach buffers
  3685	 * to the transaction appropriately.
  3686	 */
  3687	static bool ext4_journalled_dirty_folio(struct address_space *mapping,
  3688			struct folio *folio)
  3689	{
  3690		WARN_ON_ONCE(!folio_buffers(folio));
> 3691		if (folio_may_be_dma_pinned(folio))
  3692			folio_set_checked(folio);
  3693		return filemap_dirty_folio(mapping, folio);
  3694	}
  3695	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (155996 bytes)