linux-ext4 - Re: [PATCH] ext2: propagate errors from ext2_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Jan 2023 17:06:52 +0100
From:   Christoph Hellwig <hch@....de>
To:     Jan Kara <jack@...e.cz>
Cc:     Christoph Hellwig <hch@....de>, jack@...e.com,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext2: propagate errors from ext2_prepare_chunk

On Mon, Jan 16, 2023 at 12:16:21PM +0100, Jan Kara wrote:
> > -		ext2_set_link(new_dir, new_de, new_page, page_addr, old_inode, 1);
> > +		err = ext2_set_link(new_dir, new_de, new_page, page_addr,
> > +				    old_inode, true);
> > +		if (err)
> > +			goto out_dir;
> >  		ext2_put_page(new_page, page_addr);
> 
> AFAICT we need to call ext2_put_page(new_page, page_addr) also in case of
> error here. I'll fix it up on commit. Thanks for the patch.

Indeed.  I was tricked by out_dir doing the cleanup, but that's for
the old entry.