linux-ext4 - Re: [PATCH 5.15 00/10] ext4 fast-commit fixes for 5.15-stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8chUKeNaULEhM+V@gmail.com>
Date:   Tue, 17 Jan 2023 22:29:36 +0000
From:   Eric Biggers <ebiggers@...nel.org>
To:     Greg KH <greg@...ah.com>
Cc:     stable@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 5.15 00/10] ext4 fast-commit fixes for 5.15-stable

Hi Greg,

On Thu, Jan 05, 2023 at 01:01:11PM +0100, Greg KH wrote:
> On Wed, Jan 04, 2023 at 11:13:49PM -0800, Eric Biggers wrote:
> > This series backports 6 commits with 'Cc stable' that had failed to be
> > applied, and 4 related commits that made the backports much easier.
> > Please apply this series to 5.15-stable.
> > 
> > I verified that this series does not cause any regressions with
> > 'gce-xfstests -c ext4/fast_commit -g auto'.  There is one test failure
> > both before and after (ext4/050).
> 
> All now queued up, thanks.
> 
> greg k-h


It's too late to fix now, but the commits in 5.15-stable all use
"Eric Biggers <ebiggers@...nel.org>" as the author instead of the From line in
the patch itself.  For example, patch 1 became:

	commit b0ed9a032e52a175683d18e2e2e8eec0f9ba1ff9
	Author: Eric Biggers <ebiggers@...nel.org>
	Date:   Wed Jan 4 23:13:50 2023 -0800

	    ext4: remove unused enum EXT4_FC_COMMIT_FAILED

	    From: Ritesh Harjani <riteshh@...ux.ibm.com>

	    commit c864ccd182d6ff2730a0f5b636c6b7c48f6f4f7f upstream.

For reference, the upstream commit is:

	commit c864ccd182d6ff2730a0f5b636c6b7c48f6f4f7f
	Author: Ritesh Harjani <riteshh@...ux.ibm.com>
	Date:   Sat Mar 12 11:09:46 2022 +0530

	    ext4: remove unused enum EXT4_FC_COMMIT_FAILED

Do you know how this happened, and how it can be prevented in the future?  I
think I sent everything out correctly, so I think this is something on your end.

- Eric