linux-ext4 - Re: [PATCH] e2fsck: subtract acl blocks when setting i_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8eJSWwlyaVjgY/2@mit.edu>
Date:   Wed, 18 Jan 2023 00:53:13 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Li Jinlin <lijinlin3@...wei.com>
Cc:     linux-ext4@...r.kernel.org,
        Zhiqiang Liu <liuzhiqiang26@...wei.com>, linfeilong@...wei.com
Subject: Re: [PATCH] e2fsck: subtract acl blocks when setting i_file_acl to
 zero

This patch is not correct.  We don't need to create a new
ext2fs_adjust_ea_refcount4 to return the h_blocks field in the
extended attribute block, since that only thing that we support is a
single xattr block.

The real issue, as Zhiqiang Liu pointed out in [1], is that we should
not be clearing the i_file_acl block is the inode is only being
truncated, and not being unlinked.

[1] https://lore.kernel.org/all/ed518b11-3c38-1c1f-a75d-3293c91f17d4@huawei.com/

						- Ted