linux-ext4 - Re: [PATCH 07/38] lib/blkid: remove 32-bit x86 byteswap assembly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AE27C93A-528E-49F6-85B5-ACF80413FD04@dilger.ca>
Date:   Tue, 24 Jan 2023 11:21:26 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Eric Biggers <ebiggers@...nel.org>, Theodore Ts'o <tytso@....edu>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 07/38] lib/blkid: remove 32-bit x86 byteswap assembly

On Jan 21, 2023, at 1:31 PM, Eric Biggers <ebiggers@...nel.org> wrote:
> 
> From: Eric Biggers <ebiggers@...gle.com>
> 
> libblkid contains 32-bit x86 assembly language implementations of 16-bit
> and 32-bit byteswaps.  However, modern compilers can easily generate the
> bswap instruction automatically from the corresponding C expression.
> And no one ever bothered to add assembly for x86_64 or other
> architectures, anyway.  So let's just remove this outdated code, which
> was maybe useful in the 90s, but is no longer useful.

I'm not sure what Ted thinks about this, but it might be time to remove
the libblkid implementation in e2fsprogs, and instead depend on the
newer version in util-linux?  However, removing it from e2fsprogs
would add an external dependency on util-linux for non-linux platforms,
though AFAIK it should still be possible to build e2fsprogs without it.

That said, I think the current patch looks fine, and you can add:

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Cheers, Andreas

> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
> lib/blkid/probe.h | 43 -------------------------------------------
> 1 file changed, 43 deletions(-)
> 
> diff --git a/lib/blkid/probe.h b/lib/blkid/probe.h
> index dea4081d0..063a5b5c0 100644
> --- a/lib/blkid/probe.h
> +++ b/lib/blkid/probe.h
> @@ -814,46 +814,6 @@ struct exfat_entry_label {
> #define _INLINE_ static inline
> #endif
> 
> -static __u16 blkid_swab16(__u16 val);
> -static __u32 blkid_swab32(__u32 val);
> -static __u64 blkid_swab64(__u64 val);
> -
> -#if ((defined __GNUC__) && \
> -     (defined(__i386__) || defined(__i486__) || defined(__i586__)))
> -
> -#define _BLKID_HAVE_ASM_BITOPS_
> -
> -_INLINE_ __u32 blkid_swab32(__u32 val)
> -{
> -#ifdef EXT2FS_REQUIRE_486
> -	__asm__("bswap %0" : "=r" (val) : "0" (val));
> -#else
> -	__asm__("xchgb %b0,%h0\n\t"	/* swap lower bytes	*/
> -		"rorl $16,%0\n\t"	/* swap words		*/
> -		"xchgb %b0,%h0"		/* swap higher bytes	*/
> -		:"=q" (val)
> -		: "0" (val));
> -#endif
> -	return val;
> -}
> -
> -_INLINE_ __u16 blkid_swab16(__u16 val)
> -{
> -	__asm__("xchgb %b0,%h0"		/* swap bytes		*/ \
> -		: "=q" (val) \
> -		:  "0" (val)); \
> -		return val;
> -}
> -
> -_INLINE_ __u64 blkid_swab64(__u64 val)
> -{
> -	return (blkid_swab32(val >> 32) |
> -		(((__u64) blkid_swab32(val & 0xFFFFFFFFUL)) << 32));
> -}
> -#endif
> -
> -#if !defined(_BLKID_HAVE_ASM_BITOPS_)
> -
> _INLINE_  __u16 blkid_swab16(__u16 val)
> {
> 	return (val >> 8) | (val << 8);
> @@ -870,9 +830,6 @@ _INLINE_ __u64 blkid_swab64(__u64 val)
> 	return (blkid_swab32(val >> 32) |
> 		(((__u64) blkid_swab32(val & 0xFFFFFFFFUL)) << 32));
> }
> -#endif
> -
> -
> 
> #ifdef WORDS_BIGENDIAN
> #define blkid_le16(x) blkid_swab16(x)
> --
> 2.39.0
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)