linux-ext4 - Re: [PATCH] tune2fs:check return value of ext2fs_mmp_update2 in rewrite_metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167470504131.8995.2593568552213830201.b4-ty@mit.edu>
Date:   Wed, 25 Jan 2023 22:50:56 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     "lihaoxiang (F)" <lihaoxiang9@...wei.com>
Cc:     "Theodore Ts'o" <tytso@....edu>, louhongxiang@...wei.com,
        linux-ext4@...r.kernel.org, linfeilong@...wei.com,
        Zhiqiang Liu <liuzhiqiang26@...wei.com>,
        "lijinlin (A)" <lijinlin3@...wei.com>
Subject: Re: [PATCH] tune2fs:check return value of ext2fs_mmp_update2 in rewrite_metadata_checksums

On Tue, 29 Nov 2022 14:58:12 +0800, lihaoxiang (F) wrote:
> Tune2fs hasn't consider about the result of executing ext2fs_mmp_update2
> when it try to rewrite_metadata_checksums. If the ext2fs_mmp_update2
> failed, multi-mount protection couldn't guard there has the only node
> (i.e. this program) accessing this device in the meantime.
> 
> We solve this problem to verify the return value of ext2fs_mmp_update2.
> It terminate rewrite_metadata_checksums and exit immediately if the
> wrong error code returned.
> 
> [...]

Applied, thanks!

[1/1] tune2fs:check return value of ext2fs_mmp_update2 in rewrite_metadata_checksums
      (no commit info)

Best regards,
-- 
Theodore Ts'o <tytso@....edu>