linux-ext4 - Re: [PATCH] mmp:fix wrong comparison in ext2fs_mmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167474888836.17682.11878698054727825163.b4-ty@mit.edu>
Date:   Thu, 26 Jan 2023 11:01:52 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     "lihaoxiang (F)" <lihaoxiang9@...wei.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Zhiqiang Liu <liuzhiqiang26@...wei.com>,
        "lijinlin (A)" <lijinlin3@...wei.com>, linfeilong@...wei.com,
        louhongxiang@...wei.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] mmp:fix wrong comparison in ext2fs_mmp_stop

On Tue, 29 Nov 2022 15:02:39 +0800, lihaoxiang (F) wrote:
> In our knowledge, ext2fs_mmp_stop use to process the rest of work
> when mmp will finish. Critically, it must check if the mmp block is
> not changed. But there exist an error in comparing the mmp and mmp_cmp.
> 
> Look to ext2fs_mmp_read, the assignment of mmp_cmp retrieve from the
> superblock of disk and it copy to mmp_buf if mmp_buf is not none
> and not equal to mmp_cmp in the meanwhile. However, ext2fs_mmp_stop
> pass the no NULL pointer fs->mmp_buf which has possed the mmp info to
> ext2fs_mmp_read. Consequently, ext2fs_mmp_read override fs->mmp_buf
> by fs->mmp_cmp so that loss the meaning of comparing themselves
> after that and worse yet, couldn't judge whether the struct of mmp
> has changed.
> 
> [...]

Applied, thanks!

[1/1] mmp:fix wrong comparison in ext2fs_mmp_stop
      (no commit info)

Best regards,
-- 
Theodore Ts'o <tytso@....edu>