linux-ext4 - Re: [PATCH] fscrypt: support decrypting data from large folios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9RhIwSzUE0/tbo/@sol.localdomain>
Date:   Fri, 27 Jan 2023 15:41:23 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-fscrypt@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH] fscrypt: support decrypting data from large folios

On Fri, Jan 27, 2023 at 11:33:57PM +0000, Matthew Wilcox wrote:
> On Fri, Jan 27, 2023 at 02:42:02PM -0800, Eric Biggers wrote:
> > +++ b/fs/buffer.c
> > @@ -307,8 +307,8 @@ static void decrypt_bh(struct work_struct *work)
> >  	struct buffer_head *bh = ctx->bh;
> >  	int err;
> >  
> > -	err = fscrypt_decrypt_pagecache_blocks(bh->b_page, bh->b_size,
> > -					       bh_offset(bh));
> > +	err = fscrypt_decrypt_pagecache_blocks(page_folio(bh->b_page),
> > +					       bh->b_size, bh_offset(bh));
> 
> FYI, Andrew's been carrying "buffer: add b_folio as an alias of b_page"
> in his tree since mid-December.  buffer_heads always point to the
> head page, aka folio.
> 
> This all looks good to me.
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Indeed, but it's not upstream yet, so I decided to use page_folio() for now to
avoid a cross-tree dependency.

- Eric