[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ae8067b4-37ef-a1ea-5cec-ee8e55c101fb@wdc.com>
Date: Fri, 3 Feb 2023 11:57:11 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: "Matthew Wilcox (Oracle)" <willy@...radead.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
CC: "linux-afs@...ts.infradead.org" <linux-afs@...ts.infradead.org>,
"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
Hugh Dickins <hughd@...gle.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"fstests@...r.kernel.org" <fstests@...r.kernel.org>
Subject: Re: [PATCH 6/5] generic: test ftruncate zeroes bytes after EOF
On 02.02.23 21:45, Matthew Wilcox (Oracle) wrote:
> + fprintf(stderr, "Truncation did not zero new bytes:\n");
> + for (i = 0; i < 5; i++)
> + fprintf(stderr, "%#x ", buf[i]);
> + fputc('\n', stderr);
>
[...]
> +
> +$here/src/truncate-zero $test_file > $seqres.full 2>&1 ||
> + _fail "truncate zero failed!"
> +
Is '_fail' really needed here? truncate-zero will spit out an error message
in case the truncation doesn't work.
Powered by blists - more mailing lists