linux-ext4 - Re: [PATCH] ext4: init error handle resource before init group descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167678522174.2723470.13391840576077064644.b4-ty@mit.edu>
Date:   Sun, 19 Feb 2023 00:40:51 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Ye Bin <yebin@...weicloud.com>, linux-ext4@...r.kernel.org,
        adilger.kernel@...ger.ca
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-kernel@...r.kernel.org,
        Ye Bin <yebin10@...wei.com>, jack@...e.cz
Subject: Re: [PATCH] ext4: init error handle resource before init group descriptors

On Thu, 19 Jan 2023 09:37:11 +0800, Ye Bin wrote:
> From: Ye Bin <yebin10@...wei.com>
> 
> Now, 's_err_report' timer is init after ext4_group_desc_init() when fill
> super. Theoretically, ext4_group_desc_init() may access to error handle
> as follows:
> __ext4_fill_super
>   ext4_group_desc_init
>     ext4_check_descriptors
>       ext4_get_group_desc
>         ext4_error
>           ext4_handle_error
>             ext4_commit_super
>               ext4_update_super
>                 if (!es->s_error_count)
>                   mod_timer(&sbi->s_err_report, jiffies + 24*60*60*HZ);
> 		  --> Accessing Uninitialized Variables
> timer_setup(&sbi->s_err_report, print_daily_error_info, 0);
> 
> [...]

Applied, thanks!

[1/1] ext4: init error handle resource before init group descriptors
      commit: 2806abcc97829d49172632db81deac9119641b78

Best regards,
-- 
Theodore Ts'o <tytso@....edu>