linux-ext4 - Re: [PATCH v2 00/11] fsverity: support for non-4K pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/1ZP9pc1Zw9xh/L@gmail.com>
Date:   Tue, 28 Feb 2023 01:30:39 +0000
From:   Eric Biggers <ebiggers@...nel.org>
To:     Jaegeuk Kim <jaegeuk@...nel.org>
Cc:     patchwork-bot+f2fs@...nel.org, linux-fscrypt@...r.kernel.org,
        aalbersh@...hat.com, linux-f2fs-devel@...ts.sourceforge.net,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH v2 00/11] fsverity: support for non-4K pages

On Tue, Feb 28, 2023 at 01:01:54AM +0000, patchwork-bot+f2fs@...nel.org wrote:
> Hello:
> 
> This series was applied to jaegeuk/f2fs.git (dev)
> by Eric Biggers <ebiggers@...gle.com>:
> 
> On Fri, 23 Dec 2022 12:36:27 -0800 you wrote:
> > [This patchset applies to mainline + some fsverity cleanups I sent out
> >  recently.  You can get everything from tag "fsverity-non4k-v2" of
> >  https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git ]
> > 
> > Currently, filesystems (ext4, f2fs, and btrfs) only support fsverity
> > when the Merkle tree block size, filesystem block size, and page size
> > are all the same.  In practice that means 4K, since increasing the page
> > size, e.g. to 16K, forces the Merkle tree block size and filesystem
> > block size to be increased accordingly.  That can be impractical; for
> > one, users want the same file signatures to work on all systems.
> > 
> > [...]
> 
> Here is the summary with links:
>   - [f2fs-dev,v2,01/11] fsverity: use unsigned long for level_start
>     https://git.kernel.org/jaegeuk/f2fs/c/284d5db5f99e
>   - [f2fs-dev,v2,02/11] fsverity: simplify Merkle tree readahead size calculation
>     https://git.kernel.org/jaegeuk/f2fs/c/9098f36b739d
>   - [f2fs-dev,v2,03/11] fsverity: store log2(digest_size) precomputed
>     https://git.kernel.org/jaegeuk/f2fs/c/579a12f78d88
>   - [f2fs-dev,v2,04/11] fsverity: use EFBIG for file too large to enable verity
>     https://git.kernel.org/jaegeuk/f2fs/c/55eed69cc8fd
>   - [f2fs-dev,v2,05/11] fsverity: replace fsverity_hash_page() with fsverity_hash_block()
>     https://git.kernel.org/jaegeuk/f2fs/c/f45555bf23cf
>   - [f2fs-dev,v2,06/11] fsverity: support verification with tree block size < PAGE_SIZE
>     https://git.kernel.org/jaegeuk/f2fs/c/5306892a50bf
>   - [f2fs-dev,v2,07/11] fsverity: support enabling with tree block size < PAGE_SIZE
>     https://git.kernel.org/jaegeuk/f2fs/c/56124d6c87fd
>   - [f2fs-dev,v2,08/11] ext4: simplify ext4_readpage_limit()
>     https://git.kernel.org/jaegeuk/f2fs/c/5e122148a3d5
>   - [f2fs-dev,v2,09/11] f2fs: simplify f2fs_readpage_limit()
>     https://git.kernel.org/jaegeuk/f2fs/c/feb0576a361a
>   - [f2fs-dev,v2,10/11] fs/buffer.c: support fsverity in block_read_full_folio()
>     https://git.kernel.org/jaegeuk/f2fs/c/4fa512ce7051
>   - [f2fs-dev,v2,11/11] ext4: allow verity with fs block size < PAGE_SIZE
>     https://git.kernel.org/jaegeuk/f2fs/c/db85d14dc5c5
> 
> You are awesome, thank you!
> -- 
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
> 

These commits reached the f2fs tree through mainline, not through being applied
to the f2fs tree.  So this email shouldn't have been sent.  Jaegeuk, can you
look into fixing the configuration of the f2fs patchwork bot to prevent this?

- Eric