linux-ext4 - Re: [PATCH] ext4: Fix comment about the 64BIT feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAAQ5wxf16dBhvZl@magnolia>
Date:   Wed, 1 Mar 2023 18:58:47 -0800
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Tudor Ambarus <tudor.ambarus@...aro.org>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix comment about the 64BIT feature

On Wed, Mar 01, 2023 at 01:38:42PM +0000, Tudor Ambarus wrote:
> 64BIT is part of the incompatible feature set, update the comment
> accordingly.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
>  fs/ext4/ext4.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 140e1eb300d1..85c153e120b9 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1387,7 +1387,7 @@ struct ext4_super_block {
>  	__le32	s_first_meta_bg;	/* First metablock block group */
>  	__le32	s_mkfs_time;		/* When the filesystem was created */
>  	__le32	s_jnl_blocks[17];	/* Backup of the journal inode */
> -	/* 64bit support valid if EXT4_FEATURE_COMPAT_64BIT */
> +	/* 64bit support valid if EXT4_FEATURE_INCOMPAT_64BIT */

Correct.
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

>  /*150*/	__le32	s_blocks_count_hi;	/* Blocks count */
>  	__le32	s_r_blocks_count_hi;	/* Reserved blocks count */
>  	__le32	s_free_blocks_count_hi;	/* Free blocks count */
> -- 
> 2.39.2.722.g9855ee24e9-goog
>