linux-ext4 - Re: [PATCH] ext4: fix cgroup writeback accounting with fs-layer encryption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167824999281.2129363.12204207098890359786.b4-ty@mit.edu>
Date:   Tue,  7 Mar 2023 23:33:22 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     linux-ext4@...r.kernel.org, Eric Biggers <ebiggers@...nel.org>
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-fscrypt@...r.kernel.org,
        stable@...r.kernel.org, Matthew Wilcox <willy@...radead.org>,
        Tejun Heo <tj@...nel.org>, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] ext4: fix cgroup writeback accounting with fs-layer encryption

On Thu, 2 Feb 2023 16:55:03 -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> When writing a page from an encrypted file that is using
> filesystem-layer encryption (not inline encryption), ext4 encrypts the
> pagecache page into a bounce page, then writes the bounce page.
> 
> It also passes the bounce page to wbc_account_cgroup_owner().  That's
> incorrect, because the bounce page is a newly allocated temporary page
> that doesn't have the memory cgroup of the original pagecache page.
> This makes wbc_account_cgroup_owner() not account the I/O to the owner
> of the pagecache page as it should.
> 
> [...]

Applied, thanks!

[1/1] ext4: fix cgroup writeback accounting with fs-layer encryption
      commit: ffec85d53d0f39ee4680a2cf0795255e000e1feb

Best regards,
-- 
Theodore Ts'o <tytso@....edu>