linux-ext4 - Re: [PATCH 1/2] ext4: fix typos in mballoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <87sfe9flg7.fsf@doe.com>
Date:   Mon, 13 Mar 2023 07:42:56 +0530
From:   Ritesh Harjani (IBM) <ritesh.list@...il.com>
To:     Kemeng Shi <shikemeng@...weicloud.com>, tytso@....edu,
        adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        shikemeng@...weicloud.com
Subject: Re: [PATCH 1/2] ext4: fix typos in mballoc

Kemeng Shi <shikemeng@...weicloud.com> writes:

> pa_plen -> pa_len
> pa_start -> pa_pstart
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> ---
>  fs/ext4/mballoc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good to me. Please feel free to add -

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>

>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 85d5e219933f..13dce6f07fa4 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -4146,7 +4146,7 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac,
>  	 * provide gurantee on number of contiguous blocks allocation since that
>  	 * depends upon free space left, etc).
>  	 * In case of inode pa, later we use the allocated blocks
> -	 * [pa_start + fe_logical - pa_lstart, fe_len/size] from the preallocated
> +	 * [pa_pstart + fe_logical - pa_lstart, fe_len/size] from the preallocated
>  	 * range of goal/best blocks [start, size] to put it at the
>  	 * ac_o_ex.fe_logical extent of this inode.
>  	 * (See ext4_mb_use_inode_pa() for more details)
> @@ -4298,7 +4298,7 @@ static void ext4_mb_use_group_pa(struct ext4_allocation_context *ac,
>  	ac->ac_status = AC_STATUS_FOUND;
>  	ac->ac_pa = pa;
>
> -	/* we don't correct pa_pstart or pa_plen here to avoid
> +	/* we don't correct pa_pstart or pa_len here to avoid
>  	 * possible race when the group is being loaded concurrently
>  	 * instead we correct pa later, after blocks are marked
>  	 * in on-disk bitmap -- see ext4_mb_release_context()
> --
> 2.30.0